feat: req/resp logging middleware #105
Open
+1,075
−43
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dannykopping
force-pushed
the
dk/request-logging-redux
branch
from
beb1aca to
d021c47
Compare
pawbana
reviewed
Jan 15, 2026
|
|
||
| resp, err := next(req) | ||
| if err != nil { | ||
| return resp, err |
Contributor
There was a problem hiding this comment.
Not sure about it but maybe it be useful to have "err" file with error?
Collaborator
Author
There was a problem hiding this comment.
Let's leave this for a future enhancement, ok?
Contributor
There was a problem hiding this comment.
sure, could you please create an issue about it?
bridge_integration_test.go
Outdated
| reqDumpData, err := os.ReadFile(reqDumpFile) | ||
| require.NoError(t, err, "request dump file should exist") | ||
| require.Contains(t, string(reqDumpData), "POST ") | ||
| require.Contains(t, string(reqDumpData), "Host:") |
Contributor
There was a problem hiding this comment.
maybe add check like require.Contains(t, string(reqDumpData), string(reqBody))
and similar for response
Collaborator
Author
There was a problem hiding this comment.
This forced me to confront the fact that map keys were not stably sorted. Thanks 👍
Collaborator
Author
This stack of pull requests is managed by Graphite. Learn more about stacking. |
dannykopping
force-pushed
the
dk/request-logging-redux
branch
from
ec13727 to
db0f11e
Compare
pawbana
reviewed
Jan 19, 2026
|
|
||
| for _, key := range headerKeys { | ||
| // Skip Content-Length since we write it explicitly above with the pretty-printed body length. | ||
| if key == "Content-Length" { |
Contributor
There was a problem hiding this comment.
nit: Host could also be skipped
Comment on lines
+137
to
+152
| // Sort header keys for deterministic output. | ||
| headerKeys := make([]string, 0, len(resp.Header)) | ||
| for key := range resp.Header { | ||
| headerKeys = append(headerKeys, key) | ||
| } | ||
| slices.Sort(headerKeys) | ||
|
|
||
| for _, key := range headerKeys { | ||
| _, sensitive := sensitiveResponseHeaders[key] | ||
| for _, value := range resp.Header[key] { | ||
| if sensitive { | ||
| value = redactHeaderValue(value) | ||
| } | ||
| fmt.Fprintf(&headerBuf, "%s: %s\r\n", key, value) | ||
| } | ||
| } |
Contributor
There was a problem hiding this comment.
Looks copy-pasty from lines 105-124.
| return []aibridge.Provider{provider.NewOpenAI(openaiCfgWithAPIDump(addr, apiKey, dumpDir))} | ||
| }, | ||
| createRequestFunc: createOpenAIChatCompletionsReq, | ||
| }, |
Contributor
There was a problem hiding this comment.
Please add test case for responses
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
Signed-off-by: Danny Kopping <[email protected]>
dannykopping
force-pushed
the
dk/request-logging-redux
branch
from
a93b2ec to
e4c2a82
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Logs the raw HTTP requests to and responses from AI providers' APIs.